Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-6463][CH] Enable cartesion product #6510

Merged
merged 2 commits into from
Jul 19, 2024
Merged

[GLUTEN-6463][CH] Enable cartesion product #6510

merged 2 commits into from
Jul 19, 2024

Conversation

lgbo-ustc
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #6463

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

unit tests

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions GitHub Actions
Copy link

#6463

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc force-pushed the cartesian_product branch from 66a46df to 2e12ac4 Compare July 18, 2024 10:18
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc force-pushed the cartesian_product branch from 2e12ac4 to afd5f5b Compare July 19, 2024 04:18
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc force-pushed the cartesian_product branch from d880856 to e929292 Compare July 19, 2024 07:36
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc requested a review from zzcclp July 19, 2024 10:13
zzcclp
zzcclp approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit 318df24 into apache:main Jul 19, 2024
7 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_07_19_2024_time.csv log/native_master_07_18_2024_e38d5b21ad_time.csv difference percentage
q1 15.41 15.67 0.262 101.70%
q2 13.26 13.80 0.541 104.08%
q3 4.18 4.45 0.268 106.40%
q4 63.47 64.46 0.991 101.56%
q5 7.81 7.27 -0.543 93.05%
q6 2.49 3.90 1.411 156.74%
q7 5.48 4.20 -1.284 76.59%
q8 9.21 5.55 -3.660 60.27%
q9 17.96 19.71 1.751 109.75%
q10 11.30 11.31 0.016 100.14%
q11 35.47 36.75 1.275 103.59%
q12 1.42 1.61 0.189 113.28%
q13 5.74 4.93 -0.807 85.93%
q14a 42.34 42.70 0.359 100.85%
q14b 39.38 42.92 3.545 109.00%
q15 2.52 2.58 0.054 102.12%
q16 38.20 38.07 -0.131 99.66%
q17 5.22 4.80 -0.422 91.92%
q18 6.25 7.61 1.358 121.72%
q19 1.93 2.44 0.502 125.97%
q20 2.32 5.85 3.531 252.19%
q21 0.96 2.59 1.627 269.73%
q22 8.29 9.46 1.176 114.20%
q23a 83.33 83.67 0.346 100.42%
q23b 103.28 101.85 -1.425 98.62%
q24a 71.73 72.01 0.281 100.39%
q24b 69.38 77.54 8.163 111.77%
q25 4.52 4.43 -0.092 97.96%
q26 4.82 3.05 -1.772 63.22%
q27 3.23 3.08 -0.155 95.21%
q28 20.58 22.11 1.531 107.44%
q29 11.07 11.38 0.310 102.80%
q30 4.41 7.93 3.519 179.85%
q31 7.38 8.05 0.673 109.12%
q32 1.10 1.15 0.050 104.52%
q33 4.85 4.84 -0.011 99.78%
q34 3.98 3.52 -0.463 88.37%
q35 7.00 6.53 -0.467 93.32%
q36 3.50 3.40 -0.106 96.97%
q37 4.04 3.80 -0.240 94.06%
q38 14.79 11.68 -3.113 78.95%
q39a 3.39 3.29 -0.095 97.19%
q39b 4.28 5.74 1.455 133.97%
q40 3.59 3.83 0.241 106.70%
q41 0.56 0.62 0.061 110.75%
q42 0.84 0.94 0.107 112.73%
q43 3.31 3.49 0.181 105.48%
q44 9.78 8.83 -0.942 90.36%
q45 3.77 3.51 -0.261 93.08%
q46 3.45 3.36 -0.088 97.44%
q47 14.38 14.15 -0.234 98.38%
q48 4.00 3.77 -0.229 94.27%
q49 9.48 9.52 0.033 100.35%
q50 22.14 21.06 -1.082 95.11%
q51 7.90 7.93 0.028 100.35%
q52 0.98 1.10 0.120 112.20%
q53 1.93 2.10 0.162 108.36%
q54 3.40 3.49 0.091 102.68%
q55 0.99 1.11 0.122 112.38%
q56 4.38 4.66 0.284 106.48%
q57 8.55 8.83 0.281 103.28%
q58 2.52 2.71 0.197 107.83%
q59 10.81 11.21 0.404 103.74%
q60 4.56 8.94 4.373 195.82%
q61 9.16 5.71 -3.450 62.36%
q62 5.24 3.89 -1.354 74.19%
q63 2.46 2.23 -0.228 90.70%
q64 48.73 50.59 1.865 103.83%
q65 14.52 13.79 -0.731 94.96%
q66 3.37 3.55 0.180 105.36%
q67 350.16 351.24 1.081 100.31%
q68 3.65 3.74 0.089 102.45%
q69 6.58 6.15 -0.426 93.53%
q70 12.66 14.14 1.484 111.72%
q71 2.31 4.34 2.034 188.18%
q72 186.70 185.26 -1.437 99.23%
q73 2.43 2.30 -0.133 94.53%
q74 25.67 26.54 0.867 103.38%
q75 23.50 23.03 -0.470 98.00%
q76 9.33 9.54 0.204 102.19%
q77 2.14 2.22 0.070 103.29%
q78 42.72 42.20 -0.520 98.78%
q79 3.73 3.56 -0.166 95.54%
q80 11.25 11.17 -0.075 99.33%
q81 5.16 5.45 0.289 105.59%
q82 5.93 10.82 4.887 182.40%
q83 5.87 1.63 -4.244 27.73%
q84 2.70 2.97 0.270 110.00%
q85 6.60 7.18 0.577 108.74%
q86 3.32 3.45 0.132 103.98%
q87 13.60 12.21 -1.390 89.79%
q88 25.17 25.33 0.156 100.62%
q89 3.24 3.27 0.026 100.79%
q90 9.15 8.66 -0.480 94.75%
q91 2.55 2.62 0.067 102.62%
q92 1.30 1.37 0.071 105.46%
q93 28.42 27.88 -0.545 98.08%
q94 21.32 21.14 -0.177 99.17%
q9 82.89 83.55 0.657 100.79%
q5 3.72 3.75 0.024 100.64%
q96 12.21 12.03 -0.185 98.49%
q97 2.04 1.96 -0.081 96.04%
q98 9.05 9.01 -0.044 99.52%
q99 9.05 9.01 -0.044 99.52%
total 1903.15 1926.30 23.144 101.22%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_07_19_2024_time.csv log/native_master_07_18_2024_e38d5b21ad_time.csv difference percentage
q1 38.59 35.27 -3.316 91.41%
q2 24.58 24.64 0.050 100.20%
q3 40.09 39.44 -0.656 98.36%
q4 32.36 32.68 0.321 100.99%
q5 74.54 74.06 -0.477 99.36%
q6 8.85 8.20 -0.650 92.66%
q7 86.39 84.24 -2.156 97.50%
q8 91.06 87.57 -3.495 96.16%
q9 126.18 125.85 -0.325 99.74%
q10 48.50 52.89 4.391 109.05%
q11 21.24 21.54 0.302 101.42%
q12 25.90 25.91 0.007 100.03%
q13 40.07 39.86 -0.208 99.48%
q14 19.71 19.08 -0.625 96.83%
q15 35.66 34.26 -1.406 96.06%
q16 14.60 15.27 0.671 104.60%
q17 107.34 106.65 -0.697 99.35%
q18 149.26 148.23 -1.028 99.31%
q19 16.15 15.21 -0.945 94.15%
q20 31.71 29.06 -2.643 91.66%
q21 265.36 270.40 5.047 101.90%
q22 12.32 12.28 -0.046 99.63%
total 1310.46 1302.57 -7.883 99.40%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzcclp zzcclp zzcclp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CH] Support CartesianProduct
3 participants
@lgbo-ustc @GlutenPerfBot @zzcclp